Skip to content

added missing optional requirement #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2022
Merged

added missing optional requirement #87

merged 3 commits into from
Aug 31, 2022

Conversation

zeerakb1
Copy link
Contributor

No description provided.

tekktrik
tekktrik requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, just one small change! You can commit the corrected library name below:

@tekktrik tekktrik linked an issue Aug 31, 2022 that may be closed by this pull request
Optional requirements missing #85
Closed
@zeerakb1 @tekktrik
Update optional_requirements.txt
2849319 
Co-authored-by: Alec Delaney <89490472+tekktrik@users.noreply.github.com>
tekktrik
tekktrik requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newline is character is needed at the end!

@zeerakb1 @tekktrik
Update optional_requirements.txt
6dacd09 
Co-authored-by: Alec Delaney <89490472+tekktrik@users.noreply.github.com>
tekktrik
tekktrik approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tekktrik tekktrik merged commit dd1d401 into adafruit:main Aug 31, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 1, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@7ce195f)
1e0cfa2 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.19 from 2.2.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#85 from scirelli/enhancement/fix_CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.10.4 from 3.10.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#87 from zeerakb1/optional_text

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 9.0.0 from 8.3.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#174 from tekktrik/dev/cirpy-8-update-pt2
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#173 from tekktrik/dev/cirpy-8-update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional requirements missing
2 participants
@zeerakb1 @tekktrik