Skip to content

Use packages= in setup.py #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

Use packages= in setup.py #13

merged 1 commit into from
Mar 29, 2021

Conversation

@dhalbert
Copy link
Contributor

This library uses a package folder, but setup.py assumed it was a single-file module.

@dhalbert dhalbert requested a review from a team March 29, 2021 01:33
jepler
jepler approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense from what I know of python packaging which admittedly is not a whole lot

@jepler
Copy link
Contributor

jepler commented Mar 29, 2021

jinx

@jepler jepler merged commit 21d5dfb into adafruit:main Mar 29, 2021
@dhalbert dhalbert deleted the setup-packages branch March 29, 2021 01:41
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 29, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a6c2669)
0b1bd3d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#13 from dhalbert/setup-packages

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.1 from 2.17.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#147 from jposada202020/api_example
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#145 from jposada202020/master
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jepler jepler jepler approved these changes

@caternuson caternuson caternuson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhalbert @jepler @caternuson