-
Notifications
You must be signed in to change notification settings - Fork 39
Vertical label Proposal #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s greater thant string length
x=position_x, | ||
y=position_y, | ||
) | ||
face.transpose_xy = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Line will make the MagTag crash and go to safe mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issue adafruit/circuitpython#4284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adafruit/circuitpython#4331 Seems to solve the problem. For testing see PR.
Closed, this will be introduced as a Feature in label.py. I found a way to make it work with label. New PR will come after REFACTOR in display_text |
As discussed during the meeting, proposal for vertical label.
Considerations
-It is true that the new architecture will change dramatically display_text, however this improvement could improve the text_label proper.
-A Vertical Progress bar with horizontal text is not very appealing
This is a Prototype to open the conversation and not a Final Version,
and (more or less, a lot of adjusting) the background box is an improvement for the text label
In an interesting topic, you will need to test this in a physical screen, blinka does not work. I tested the code below in a WIO Terminal using Adafruit CircuitPython 6.1.0
Maybe it could be included in the community bundle. I let you folks decide. (Iy you want my opinion label text should be more open to other languages, where you write from top to bottom, and from left to right)
@FoamyGuy @jepler @kmatch98
@jepler reporting that it could be done :). Thanks for the info, and if it was you also for the amazing transpose_xy function