Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue 17 - sleep() throws error #18

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Fixes issue 17 - sleep() throws error #18

merged 2 commits into from
Jun 9, 2024

Conversation

dargus
Copy link
Contributor

@dargus dargus commented May 27, 2024

b"" does not pass properly to the i2cdisplay function as it tries to concatenate a list with a byte string.

@dargus
Fixes issue 17 - sleep() throws error
48b11c8 
b"" does not pass properly to the i2cdisplay function as it tries to concatenate a list with a byte string.
@dargus dargus mentioned this pull request May 29, 2024
Closed
tannewt
tannewt requested changes May 29, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This well send an extra null byte. Did you try [] instead?

@dargus
Removed extra null byte being sent on displayio_sh1106
1640886 
Removed extra null byte being sent to the bus.
@dargus
Copy link
Contributor Author

dargus commented May 29, 2024

I had not tried that. Confirmed that it works in my code.

@dargus dargus requested a review from tannewt May 29, 2024 20:02
EAGrahamJr
EAGrahamJr reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@EAGrahamJr EAGrahamJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I like it 😀

FoamyGuy
FoamyGuy approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The requested change was made in the latest commit.

Thank you @dargus!

@FoamyGuy FoamyGuy merged commit b8a89e9 into adafruit:main Jun 9, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 10, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d723e94)
672526d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.7.6 from 3.7.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#71 from FoamyGuy/issueadafruit/Adafruit_CircuitPython_BME680#69

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#18 from dargus/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EAGrahamJr EAGrahamJr EAGrahamJr left review comments

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dargus @tannewt @FoamyGuy @EAGrahamJr