mode setter enables changes and honors delays. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
reviewed
May 4, 2019
adafruit_bno055.py
Outdated
|
|
||
| @mode.setter | ||
| def mode(self, new_mode): | ||
| self._write_register(_MODE_REGISTER, _CONFIG_MODE) # Empirically necessary |
There was a problem hiding this comment.
_CONFIG_MODE is not defined, needs to be CONFIG_MODE
adafruit_bno055.py
Outdated
| @mode.setter | ||
| def mode(self, new_mode): | ||
| self._write_register(_MODE_REGISTER, _CONFIG_MODE) # Empirically necessary | ||
| time.sleep_ms(0.02) # Datasheet table 3.6 |
There was a problem hiding this comment.
I think this needs to be time.sleep(0.02).
adafruit_bno055.py
Outdated
| def mode(self, new_mode): | ||
| self._write_register(_MODE_REGISTER, _CONFIG_MODE) # Empirically necessary | ||
| time.sleep_ms(0.02) # Datasheet table 3.6 | ||
| if new_mode != _CONFIG_MODE: |
There was a problem hiding this comment.
Same here for _CONFIG_MODE
|
You are right. Now updated. |
|
Looks good. Tested: Adafruit CircuitPython 3.1.2 on 2019-01-07; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import adafruit_bno055
>>> from busio import I2C
>>> from board import SDA, SCL
>>> i2c = I2C(SCL, SDA)
>>> imu = adafruit_bno055.BNO055(i2c)
>>> imu.mode
12
>>> imu.mode = 5
>>> imu.mode
5
>>> |
caternuson
approved these changes
May 9, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 10, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#28 from caternuson/iss26_continuous > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#31 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#14 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.0.6 from 3.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#27 from peterhinch/mode-fix > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#25 from peterhinch/issues_23_24 Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.3.2 from 3.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#23 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.3.5 from 4.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#50 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#19 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#9 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#5 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#18 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.1 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#33 from ChewyTurtle/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#5 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.6.3 from 2.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#25 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#8 from dherrada/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with the mode setter.
Firstly, as per issue #26, it is necessary to set
_CONFIG_MODEprior to making any other mode change. The datasheet is misleading on this but it is empirically necessary.Secondly the datasheet mandates delays after setting and clearing
_CONFIG_MODE.Please note that I have no means of running CircuitPython: I have tested this code against MicroPython only.