Description
There are missing type annotations for some functions in this library.
The typing
module does not exist on CircuitPython devices so the import needs to be wrapped in try/except to catch the error for missing import. There is an example of how that is done here:
try:
from typing import List, Tuple
except ImportError:
pass
Once imported the typing annotations for the argument type(s), and return type(s) can be added to the function signature. Here is an example of a function that has had this done already:
def wrap_text_to_pixels(
string: str, max_width: int, font=None, indent0: str = "", indent1: str = ""
) -> List[str]:
If you are new to Git or Github we have a guide about contributing to our projects here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github
There is also a guide that covers our CI utilities and how to run them locally to ensure they will pass in Github Actions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code In particular the pages: Sharing docs on ReadTheDocs
and Check your code with pre-commit
contain the tools to install and commands to run locally to run the checks.
If you are attempting to resolve this issue and need help, you can post a comment on this issue and tag both @FoamyGuy and @kattni or reach out to us on Discord: https://adafru.it/discord in the #circuitpython-dev
channel.
The following locations are reported by mypy to be missing type annotations:
- adafruit_bno055.py:142
- adafruit_bno055.py:146
- adafruit_bno055.py:150
- adafruit_bno055.py:155
- adafruit_bno055.py:160
- adafruit_bno055.py:164
- adafruit_bno055.py:172
- adafruit_bno055.py:347
- adafruit_bno055.py:381
- adafruit_bno055.py:500
- adafruit_bno055.py:518
- adafruit_bno055.py:538
- adafruit_bno055.py:558
- adafruit_bno055.py:578
- adafruit_bno055.py:598
- adafruit_bno055.py:618
- adafruit_bno055.py:638
- adafruit_bno055.py:658
- adafruit_bno055.py:667
- adafruit_bno055.py:670
- adafruit_bno055.py:706
- adafruit_bno055.py:766
- adafruit_bno055.py:771
- adafruit_bno055.py:777
- adafruit_bno055.py:789
- adafruit_bno055.py:794
- adafruit_bno055.py:807
- adafruit_bno055.py:871
- adafruit_bno055.py:882
- adafruit_bno055.py:893
- adafruit_bno055.py:904
- adafruit_bno055.py:915