Missing Type Annotations #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added return values imported SPI and DigitalInOut to use the types for __init__ on BMP_SPI. imported 'optional' from typing for the same function.
tekktrik
requested changes
Apr 11, 2022
|
Thanks for the comments and tips! I appreciate the very helpful review. I'll resolve these in a jiffy |
Revert "added return values to the remaining setters" This reverts commit 84f1bb4.
changed a return type from int to None which i set wrong in an earlier commit
imported I2C from busio.i2c
…nit func on the SPI class. Added return types for a few more fucntions
|
@tekktrik changed as per suggestions, and added return types for all functions in this file. Thanks again for the helpful comments! this is my first time contributing so I'm happy to help out! |
|
Thanks for making these changes and contributing the typing info @billvanleeuwen424! I've got this one on my list to take a look over later on today as well. Congratz on your first contribution and thanks again for helping us out! 🎉 |
FoamyGuy
requested changes
Apr 11, 2022
There was a problem hiding this comment.
I have a few more requested changes. But it's looking good to me beyond these. Thanks again @billvanleeuwen424
|
Ah my bad on those! Thanks for the catch |
FoamyGuy
approved these changes
Apr 13, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 13, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.2.13 from 3.2.12: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#36 from billvanleeuwen424/typeAnnotations Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.1.0 from 5.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#115 from kattni/buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added types for returns and inputs to all of the functions mentioned in the issue.
imported 2 types (SPI and Digital InOut from busio, and digitalio respectively), and imported Optional from typing.