Add READ & NOTIFY Permissions to Battery Service #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allowed me to be able to read the battery service characteristic from nRF Connect as well as a forked version of GadgetBridge. The unmodified code has properties equal to 0 for this service. Reference this forum post: https://forums.adafruit.com/viewtopic.php?f=60&t=167056.
tannewt
approved these changes
Jul 13, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 17, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.1.0 from 5.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#52 from adafruit/docs-update > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#54 from adafruit/i2c-gpio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.0.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#21 from jerryneedell/jerryn_fingersearch Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.0.3 from 7.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#95 from madgrizzle/patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#26 from dunkmann00/dotstar-brightness Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.3.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#21 from razvanphp/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allowed me to be able to read the battery service characteristic from nRF Connect as well as a forked version of GadgetBridge. The unmodified code has properties equal to 0 for this service. Reference this forum post: https://forums.adafruit.com/viewtopic.php?f=60&t=167056.