-
Notifications
You must be signed in to change notification settings - Fork 10
Adding Clear and NIR accessors #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adding Clear and NIR accessors
adding clear and NIR examples to readme
This is for #18? Were you able to test this code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed accessor for channel_nir
I have not tested this code yet, but I will try to tonight to verify - since I'm just adding accessors for data that was already in the driver, I'm fairly confident it'll work but I will test to verify and report back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated channel_nir and reviewed changes
It looks like the CI is failing on the formatting check. See here for info on how to run Black: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated file
OK, the file had CRLF line endings, now has just LF, ran pre-commit on my end and it looks good, pushed new version so should be set to re-run CI tests |
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#19 from bjones14/main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.4.1 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#10 from lesamouraipourpre/cpython > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#9 from lesamouraipourpre/multiplex Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.5.7 from 0.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#41 from PontusO/main Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#5 from adafruit/philb-bytes > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#3 from rhooper/grid > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#4 from adafruit/philb-buffer Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.0 from 8.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#135 from tannewt/connect_to_address Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.3 from 1.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#41 from EMATech/mtc Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.9.2 from 1.9.1: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#49 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_UC8151D
No description provided.