Skip to content

Adding Clear and NIR accessors #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2021
Merged

Adding Clear and NIR accessors #19

merged 6 commits into from
Sep 9, 2021

Conversation

bjones14
Copy link
Contributor

No description provided.

@bjones14 bjones14 changed the title adding Clear and NIR accessors Adding Clear and NIR accessors Aug 28, 2021
This was referenced Aug 28, 2021
adding clear and NIR examples to readme
@ladyada ladyada requested a review from caternuson August 30, 2021 17:13
@caternuson
Copy link
Contributor

This is for #18?

Were you able to test this code?

Copy link
Contributor Author

@bjones14 bjones14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed accessor for channel_nir

@bjones14
Copy link
Contributor Author

bjones14 commented Sep 2, 2021

This is for #18?

Were you able to test this code?

I have not tested this code yet, but I will try to tonight to verify - since I'm just adding accessors for data that was already in the driver, I'm fairly confident it'll work but I will test to verify and report back

Copy link
Contributor Author

@bjones14 bjones14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated channel_nir and reviewed changes

@bjones14 bjones14 requested a review from caternuson September 6, 2021 04:21
@caternuson
Copy link
Contributor

It looks like the CI is failing on the formatting check. See here for info on how to run Black:
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/black

Copy link
Contributor Author

@bjones14 bjones14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated file

@bjones14
Copy link
Contributor Author

bjones14 commented Sep 7, 2021

It looks like the CI is failing on the formatting check. See here for info on how to run Black:
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/black

OK, the file had CRLF line endings, now has just LF, ran pre-commit on my end and it looks good, pushed new version so should be set to re-run CI tests

@caternuson caternuson merged commit 0577cd5 into adafruit:main Sep 9, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 22, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#19 from bjones14/main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#10 from lesamouraipourpre/cpython
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#9 from lesamouraipourpre/multiplex

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.5.7 from 0.5.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#41 from PontusO/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#5 from adafruit/philb-bytes
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#3 from rhooper/grid
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#4 from adafruit/philb-buffer

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.0 from 8.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#135 from tannewt/connect_to_address

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.3 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#41 from EMATech/mtc

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.9.2 from 1.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#49 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_UC8151D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants