Skip to content

Conversation

@marcmerlin
Copy link
Contributor

@marcmerlin marcmerlin commented May 12, 2019

This is a hello world GFX demo I've written and ported to multiple GFX supported backends.
It is not fully optimized for SD1331 but simply meant to show how it works on that backend, including the issue of clear() being slow.
One big plus is that it shows how to display bitmaps (missing from the existing demo included with the code)

This same demo is already present in these 2 Adafruit trees:

If you have a good memory of ancient times, you may think "mmmh, some of this code looks familiar", and you would be right :) See https://github.com/adafruit/Adafruit_LED_Backpack/blob/master/examples/matrix8x8/matrix8x8.ino

and other similar GFX compatible backends:

@marcmerlin
Copy link
Contributor Author

build failure is totally unrelated to my change which touches no existing code

Picked up JAVA_TOOL_OPTIONS: 
Loading configuration...
Initializing packages...
Preparing boards...
Verifying...
In file included from /home/travis/build/adafruit/Adafruit-SSD1331-OLED-Driver-Library-for-Arduino/examples/displayOnOffTest/displayOnOffTest.ino:13:0:
/home/travis/.arduino15/packages/adafruit/hardware/samd/1.4.1/cores/arduino/Arduino.h:48:17: fatal error: sam.h: No such file or directory
 #include "sam.h"
                 ^
compilation terminated.
exit status 1

@makermelissa
Copy link
Collaborator

Cache cleared and build restarted.

@marcmerlin
Copy link
Contributor Author

Two samples:
image
image

80Mhz works for me after first init, but it slightly unstable on first
run, so default back to 40Mhz.
Shows incredible improvement from 3.68fps to 86.96fps.
Added new count_writePixels benchmark vs single pixel pushes.
@marcmerlin
Copy link
Contributor Author

marcmerlin commented May 13, 2019

Any idea why travis keeps breaking on unrelated changes?
Either way, I forgot to originally mention (just edited the text) to say that it's a very evolved version of your own code written for your first 2D display (IIRC)
https://github.com/adafruit/Adafruit_LED_Backpack/blob/master/examples/bicolor8x8/bicolor8x8.pde
It's a bit like vger is from voyager, but still wanted to credit you for the original roots :)

@makermelissa
Copy link
Collaborator

You could try switching to the board and sketch it’s failing on and compile them on your computer.

@marcmerlin
Copy link
Contributor Author

marcmerlin commented May 13, 2019

@makermelissa first, nice to see you helping out on bugs and PRs, thank you for your help :)
Back to the issue, after the flake in travis, I looked at the wrong travis report and missed that this one was actually my fault as shown in https://travis-ci.com/adafruit/Adafruit-SSD1331-OLED-Driver-Library-for-Arduino/builds/111514114
Not a bug, but I used a type that doesn't work on all CPUs. Fixed now.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good. Thanks.

@makermelissa makermelissa merged commit e2b49fe into adafruit:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants