Add N-API subproject to run node-semver test eventually #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Jan 26, 2025
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we add package-lock and use npm? Yarn might be hard to maintain in the long term.
|
Can you also run the shell script in tools folder to format the code using clang-format-17 |
lemire
approved these changes
Jan 26, 2025
anonrig
approved these changes
Feb 27, 2025
|
I'm not sure why I can't seem to make it work on Linux CI, but at least it should tell us if a node-semver test starts failing/passing |
|
hey @aduh95, any plans to continue working on version_weaver? |
|
I mean, the project still sounds interesting, but it's just hard to find time for it now that I have a job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that we could eventually run the node-semver test suite.
Use the following commands to build: