Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an intermittent issue identified by @isaacs in nodejs/node#49960
I also add
quiet
to thefind_package(ZURI)
request since most people will not haveZURI
installed on their machine.Performance
I am using
benchdata
to assess the performance impact.There is a tiny performance impact (Apple M2, LLVM 14) of about 1%. It is small enough to be ignored (likely to go away or flip in another direction if you change compiler or processor).
Main branch:
This PR:
For x64, I am using an Ice Lake server with GCC 12. The effect of this PR is beneficial.
Main branch:
This PR: