This corrects two instances of unsafe C++ code. #33
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this because I consider that these two changes ought to be uncontroversial. The prior code was clearly unsafe. |
anonrig
reviewed
Jan 6, 2023
| // We cast to an unsigned 8-bit integer because | ||
| // *pointer is of type 'char' which may be signed or unsigned. | ||
| // A negative index access in 'character_sets::hex' is unsafe. | ||
| url.path += character_sets::hex[uint8_t(*pointer) * 4]; |
There was a problem hiding this comment.
This is also used inside unicode.cpp. We should update it too.
There was a problem hiding this comment.
I have not seen other such problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.