Repository navigation
Fix error in optimized can_parse - #1118
Merged
anonrig merged 4 commits intoApr 3, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## yagiz/optimize-canparse #1118 +/- ##
===========================================================
+ Coverage 59.64% 59.67% +0.03%
===========================================================
Files 37 37
Lines 5957 5957
Branches 2907 2906 -1
===========================================================
+ Hits 3553 3555 +2
+ Misses 595 594 -1
+ Partials 1809 1808 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CarlosEduR
marked this pull request as ready for review
April 3, 2026 00:40
anonrig
merged commit Apr 3, 2026
77c6d5f
into
ada-url:yagiz/optimize-canparse
18 of 63 checks passed
anonrig
added a commit
that referenced
this pull request
Apr 5, 2026
* optimize url::can_parse method * update clang-tools to 22 * create AGENTS.md * remove unused methods * update comments & abi-check * bump SOVERSION to 5 for intentional ABI break * fix clang-tidy-22 warnings: noexcept-escape, unchecked-optional-access, throwing-static-init * address fuzzing issues * fix throwing-static-init false positive and add clang-tidy to run-clangcldocker.sh * fix docker clang-tidy: generate compile_commands.json on host, run tidy in container * fix gen_compile_commands: drop -stdlib=libc++ when using host GCC * wipe stale cmake cache before gen_compile_commands to drop old CXX_FLAGS * fix docker clang-tidy: install cmake+ninja in container, use clang++-22 to match CI exactly * wipe build-clang-tidy before docker cmake to avoid generator mismatch * install clang-22 and libc++-22-dev in docker tidy container * reduce apt-get verbosity with -qq flag * add git to docker deps for CPM to clone gtest * suppress apt/docker verbosity, fix SSL certs, cache CPM downloads on host * exclude vendored gtest from clang-tidy and update ExcludeHeaderFilterRegex * scope clang-tidy to src/ only, fix git safe.directory, simplify docker setup * fix all clang-tidy issues: scope to ada.cpp, NOLINT false positives, fix stringview usage, update AGENTS.md * remove .cpm-cache from repo, add to .gitignore * add regression tests for extra-slash fuzzer crashes (ws:///..., ws://////5...) * fix % in host: return nullopt to defer to full parser; add regression tests for all fuzzer crashes * fix port leading-zeros: strip zeros before pl>5 check; add regression tests * fix IPv4 fast path bypassing port validation; add regression test * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * add shortcuts for can_parse slow path * optimize even further (#1111) * Fix error in optimized can_parse (#1118) * Improve consistency in optimized can_parse (#1119) --------- Co-authored-by: Carlos Sousa <40635471+CarlosEduR@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.