Conversation
| val ranges: Gen[Range] = for(size <- sizes) yield 0 until size | ||
| performance of "Range" in { | ||
| measure method "transform" config(exec.benchRuns -> benchRuns) in { | ||
| measure method "transform" in { |
There was a problem hiding this comment.
Benchmark configuration value read but never used
Low Severity
The benchRuns variable is read from configuration on line 37 but is never used anywhere in the code. The config(exec.benchRuns -> benchRuns) syntax that previously applied this configuration to the scalameter benchmark was removed on line 44, making benchRuns dead code. The benchmark will now ignore the user-configured number of runs and use scalameter's default instead.
Additional Locations (1)
| -e TWINE_USERNAME="$TWINE_USERNAME" \ | ||
| -e TWINE_PASSWORD="$TWINE_PASSWORD" \ | ||
| mleap:ci bash sbt publishSigned | ||
| mleap:ci bash -c "source travis/extract.sh && source travis/docker.sh && sbt '+ publishSigned' 'mleap-serving/docker:publish' 'mleap-spring-boot/docker:publish'" |
There was a problem hiding this comment.
Publish workflow uses incompatible Travis CI scripts
High Severity
The publish command was changed to source travis/extract.sh before running sbt. This script requires Travis CI-specific encrypted environment variables ($encrypted_21bd84d1dece_key and $encrypted_21bd84d1dece_iv) that aren't configured or passed to the Docker container in the GitHub Actions workflow. The workflow only passes GPG_SECRET_KEY, GPG_PASSPHRASE, and Sonatype/Twine credentials. When a release is published, the job will fail because the openssl decryption in travis/extract.sh will error due to missing key/iv variables.
| python3.10-venv \ | ||
| python3.11 \ | ||
| python3.12 \ | ||
| python3.7-distutils \ |
There was a problem hiding this comment.
Missing venv package for Python 3.11 tests
Medium Severity
The Dockerfile installs python3.9-venv and python3.10-venv packages but omits python3.11-venv. On Ubuntu with deadsnakes PPA, the -venv package provides the ensurepip module required for virtual environment creation. When the python311-tests workflow runs tox -e py311, tox will fail to create the virtual environment with "ensurepip is not available" error. This inconsistency (3.9 and 3.10 have venv packages, 3.11 doesn't) appears to be an oversight.
his pr is merging the branch of this combust#887 which implemented scala 2.13 support into master
Note
Major platform upgrades and compatibility adjustments across the codebase.
2.13.16, Java17, Spark4.0.1, Hadoop3.4.0, XGBoost2.0.3, Spring Boot3.2, Logback1.4.14; update README matrix and usage examples to0.24.0.toSeq,ArraySeq, JavaConverters -> CollectionConverters), minor API tweaks (e.g.,dataset.sparkSession.sqlContext), and constructor signature fixes in serializersArrayRowusesArraySeq, adjust UDF arg normalization and row transformers; Avro/JSON converters return strictSeq/Map3.9-3.13; publish step invokes aggregated sbt/docker targets>=3.9, tox envs updated,pyspark==4.0.1Written by Cursor Bugbot for commit ea83d54. This will update automatically on new commits. Configure here.