-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pragma once
with explicit header guards
#1908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1908 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 411 411
Lines 40111 40113 +2
Branches 4539 4539
=======================================
+ Hits 36366 36368 +2
- Misses 2398 2400 +2
+ Partials 1347 1345 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
This reverts commit fdf2e75 Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
This reverts commit 64bbc4e.
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Conformance check passed ✅No test result changes. |
|
pragma once
with explicit header guards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While being practical when writing,
#pragma once
has several downsides.This PR replaces all occurences of
#pragma once
by explicit header guards. The header guard macros contain the project name and the full path to the file and the filename, so they are very robust against collisions (e.g.QLEVER_SRC_ENGINE_OPERATION_H
for the filesrc/engine/Operation.h
.The replacement has been performed by a Python script which is also checked in as part of this PR.