Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a custom reverse implementation by ql::ranges #1894

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Mar 21, 2025

In the SPARQL parser there was a custom Reverse struct, that was just a poor man's version of ql::ranges::reverse. This PR removes this struct.

@RobinTF RobinTF force-pushed the remove-reverse-wrapper branch from 046b579 to ebd0803 Compare March 21, 2025 17:37
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (09d5caa) to head (ebd0803).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   90.61%   90.60%   -0.01%     
==========================================
  Files         405      405              
  Lines       39745    39742       -3     
  Branches     4489     4489              
==========================================
- Hits        36013    36008       -5     
  Misses       2396     2396              
- Partials     1336     1338       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sparql-conformance
Copy link

@joka921 joka921 changed the title Replace own reverse wrapper with ranges library Replace a custom reverse implementation by ql::ranges Mar 24, 2025
@joka921 joka921 merged commit 1854a25 into ad-freiburg:master Mar 24, 2025
24 checks passed
@RobinTF RobinTF deleted the remove-reverse-wrapper branch March 24, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants