Don't apply language filter if no matching triple pattern exists #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
==========================================
- Coverage 90.52% 90.52% -0.01%
==========================================
Files 403 403
Lines 39308 39316 +8
Branches 4429 4433 +4
==========================================
+ Hits 35585 35591 +6
- Misses 2401 2403 +2
Partials 1322 1322 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Conformance check passed ✅No test result changes. |
|
joka921
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QLever has two efficient ways of applying language filter: One using the tagged predicates like
@en@rdfs:labeland one that joins with theql:langtagpredicate. The latter one can only be safely applied, if the filtered variable appears somewhere in a triple, otherwise entities with a language tag that are created by the query (e.g. in a VALUES clause) are filtered out even if they have the correct language tag. This last restriction was missing so far and is introduced via this PR.Fixes #1312