Add STDEV() aggregate function
#1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
=======================================
Coverage 89.21% 89.22%
=======================================
Files 372 374 +2
Lines 34723 34795 +72
Branches 3915 3921 +6
=======================================
+ Hits 30979 31046 +67
- Misses 2471 2472 +1
- Partials 1273 1277 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
joka921
requested changes
Nov 12, 2024
Conformance check passed ✅No test result changes. |
joka921
approved these changes
Nov 12, 2024
|
|
Thank you for this, it's a really useful shortcut! There were quite a few complaints from SonarCloud, please have another quick look whether any of these should be addressed. |
|
@hannahbast We have undone the merge and reopened this PR as #1614. I will address the Sonarcloud problems there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new aggregate function
STDEV(X)which computes the (sample) standard deviation, such that a user will not have to repetitively typemath:sqrt(sum(math:pow((X - avg(X)), 2)) / (count(*) - 1)). This is not part of the SPARQL standard, but also doesn't cause any conflicts.