Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FROM NAMED #1520

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Implement FROM NAMED #1520

merged 6 commits into from
Oct 1, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Sep 27, 2024

This continues work from #1445. QLever now supports SPARQL queries with FROM NAMED and GRAPH with a variable.

Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (d0302b7) to head (ca7e252).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
+ Coverage   88.14%   88.18%   +0.04%     
==========================================
  Files         359      359              
  Lines       27028    27061      +33     
  Branches     3652     3655       +3     
==========================================
+ Hits        23824    23864      +40     
+ Misses       1953     1951       -2     
+ Partials     1251     1246       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes, minor changes left, awesome that this works now!

Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@hannahbast hannahbast changed the title Implement FROM NAMED clauses. Implement FROM NAMED Sep 30, 2024
Copy link

sonarcloud bot commented Sep 30, 2024

@hannahbast hannahbast merged commit 996315f into ad-freiburg:master Oct 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants