SPARQL Update Part 2: DeltaTriples #1429
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
- Coverage 94.14% 88.21% -5.94%
==========================================
Files 347 361 +14
Lines 25641 27132 +1491
Branches 3450 3661 +211
==========================================
- Hits 24141 23935 -206
- Misses 1458 1952 +494
- Partials 42 1245 +1203 ☔ View full report in Codecov by Sentry. |
|
| explicit DeltaTriples(const Index& index) : index_(index) {} | ||
|
|
||
| // Get the common `LocalVocab` of the delta triples. | ||
| LocalVocab& localVocab() { return localVocab_; } |
There was a problem hiding this comment.
Is it a good idea to make this mutable getter public?
It lets us introduce very very very nasty bugs.
There was a problem hiding this comment.
Made it private for now.
Mutable LocalVocabs are used in LocatedTriples and the execution of normal queries (though these are currently temporary). These two need to be in sync for the retrieval of IDs while querying. The temporary IDs that a generated while querying (e.g. Service) can be discarded. Given the constraints I decided on a single global LocalVocab. This is a point that is still open for the integration PR.
There was a problem hiding this comment.
Yes,
I think that issues like "how do we clean up the local vocab, when the inserted entries are not needed anymore"
Can be postponed to the future, as it is probably related with the question "how do we deal with concurrent updates" (in particular updates that run concurrently with queries.).
# Conflicts: # src/index/CMakeLists.txt
# Conflicts: # src/index/CMakeLists.txt
|
DeltaTriplesmanage onLocatedTriplesobject per permutation. Insertions/Deletions of (sets of) triples are processed byDeltaTriples.