Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of
SpatialJoin
#1248Initial implementation of
SpatialJoin
#1248Changes from 59 commits
0fe8bd2
4497ae5
1b49817
16381e7
6084f6d
522cef2
95e39ec
22e3276
16e47a6
6783ddb
2f1146f
d40b5c1
f49918f
0ca9bbe
04af121
4a79fc3
d202972
0f55a78
fd0dae9
a76bbb1
df7084b
b6add0d
12435ce
87c42a8
d5913fe
cbce5bf
6656863
d2d79bc
10ab4d5
36e7ccd
b6ecb85
46ae079
97ffea8
f0f6ad2
c21db7f
076288e
ec18b02
702b0c4
42439f9
d672f8d
345e369
2e1f7db
5cc5fba
9e083a1
7b964f7
d90ea82
707cc32
53dfcf5
d33ac37
b64e4a2
a91456f
35240bd
884ceb5
81c09a2
a1e9dd1
ece9b0b
dca72ac
ef95bb3
40ffa04
84ae818
63fadec
2f263f0
de2c3f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1748 in src/engine/QueryPlanner.cpp
Codecov / codecov/patch
src/engine/QueryPlanner.cpp#L1748
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this.
If the spatial join is complete, then it should have no more open variables, and thus we never reach this code.
Should this be an assertion, (AD_CORRECTNESS_CHECK), because I don't see how this can be triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah,
I now understand this...
You don't need
isConstructed
here,but you need "is the single variabel that I want to bind here already bound"..
Considder for example
The query planner has to pick one of the triples
1
or2
as the left side of the spatial join. I think currently is allowed by this code to bind both of them. And this wouldn't be correct (one of the triples would be ignored/overwritten).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's not necessary to check, if the singe variable i want to bind is already bound because of the following reason: as soon as this one variable, here y, has been added, the variableToColumnMap returns one column, which only contains z. Therefore, the QueryPlanner can only join it with z variables. The behavior* of the VariableToColumnMap prevents this case.
*Behavior of VariableToColumnMap: If no child has been added, it returns the two variables of its children in it's map. As soon as one child has been added, it returns only one column, containing the missing child. When both children are finally added, it returns the "true" VariableToColumnMap, which contains the merged results from it's children