new: when validating a ref object update attribute path in data#25
Open
primalmotion wants to merge 2 commits intomasterfrom
Open
new: when validating a ref object update attribute path in data#25primalmotion wants to merge 2 commits intomasterfrom
primalmotion wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
@chris-acuvity please test.
|
Contributor
|
I tried to generate the errors and it looks good! |
chris-acuvity
approved these changes
Feb 5, 2026
e6a4f09 to
f0b1936
Compare
It is convention that elemental.Error Data can hold a map[string]any or map[string]string that may have a key 'attribute' giving the attribute name to which the error relates to. This patch adds a function that update the attribute key to hold the full path of the position of the error in the object. For instance, if you miss parent.children[0].name that is required, instead of having the attribute key set to 'name' it will be set to 'parent/children/0/name'.
f0b1936 to
9ed2731
Compare
Contributor
|
Can you try to see if it works for you on Acumux too? We want to make sure it's fine before merging this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is convention that elemental.Error Data can hold a map[string]any or map[string]string that may have a key 'attribute' giving the attribute name to which the error relates to.
This patch adds a function that update the attribute key to hold the full path of the position of the error in the object.
For instance, if you miss parent.children[0].name that is required, instead of having the attribute key set to 'name' it will be set to 'parent/children/0/name'.