Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 update "how to cut a release" doc #461

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

MatissJanis
Copy link
Member

No description provided.

@actual-github-bot actual-github-bot bot changed the title 📝 update "how to cut a release" doc [WIP] 📝 update "how to cut a release" doc Oct 3, 2024
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for actualbudget-website ready!

Name Link
🔨 Latest commit f9cd1d4
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget-website/deploys/66fed8ac9106750008e0a6ac
😎 Deploy Preview https://deploy-preview-461.www.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines -70 to +76
__Login to the Microsoft Partner Center:__
**Login to the Microsoft Partner Center:**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These formatting changes are coming from prettier. Would be nice to add a pre-commit hook to this repo that would run prettier on the staged files. 💡

@MatissJanis MatissJanis changed the title [WIP] 📝 update "how to cut a release" doc 📝 update "how to cut a release" doc Oct 3, 2024

After the release is out on `actual-server` - remember to deploy it and do a quick smoke test to verify things still work as expected. If they do: continue with sending an announcement on Discord and Twitter.

:tada:

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error documentation

tada is not a recognized word. (unrecognized-spelling)

This comment has been minimized.

@MatissJanis

This comment has been minimized.

Update for https://github.com/actualbudget/docs/actions/runs/11166959821/attempts/1
Accepted in #461 (comment)

Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com>
on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev>
Copy link

github-actions bot commented Oct 3, 2024

⌛ check-spelling changes applied

As configured, the commit pushed by @check-spelling-bot to GitHub doesn't trigger GitHub workflows due to a limitation of the @github-actions system.

Users with the Admin role can address this for future interactions 🪄

Create a deploy key and secret

(
  set -e
  brand=check-spelling; repo='actualbudget/docs'; SECRET_NAME=CHECK_SPELLING
  cd "$(mktemp -d)"
  ssh-keygen -f "./$brand" -q -N "" -C "$brand key for $repo"
  gh repo deploy-key add "./$brand.pub" -R "$repo" -w -t "$brand-talk-to-bot"
  gh secret -R "$repo" set "$SECRET_NAME" < "./$brand"
)

Configure update job in workflow to use secret

If the .github/workflows/spelling.yml workflow Update PR job doesn't already have the check-spelling/with/ssh_key, then add them:

    name: Update PR
    ...
    steps:
    ...
    - name: apply spelling updates
      uses: ${action_ref:-check-spelling/check-spelling@...}
      with:
        checkout: true
+       ssh_key: "${{ secrets.CHECK_SPELLING }}"

To trigger another validation round and hopefully a ✅, please add a blank line, e.g. to .github/actions/spelling/expect.txt and commit the change.

@MatissJanis MatissJanis merged commit d27a135 into master Oct 4, 2024
1 check passed
@MatissJanis MatissJanis deleted the matiss/cut-release branch October 4, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants