Skip to content

feat: Enable MultiStepper based on SympyStepper #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Aug 5, 2025

This generalizes the MultiEigenStepperLoop to the MultiStepperLoop, that can take an arbitrary single-component stepper as basis. The stepper concepts are modified accordingly. Tests for the MultiSympyStepperLoop are added.

The config constructor of the multi-stepper was broken (did not compile) and is now fixed. The change in that constructor is not considered breaking.

The MultiEigenStepperLoop.hpp header is kept for compatibility.

@benjaminhuth benjaminhuth added this to the v44.0.0 milestone Aug 5, 2025
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 5, 2025
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like! 👍

IMO we could drop the MultiEigenStepperLoop.hpp if this is a breaking change anyways

@andiwand andiwand marked this pull request as draft August 5, 2025 11:55
@andiwand
Copy link
Contributor

andiwand commented Aug 5, 2025

drafting because of ci failure and ci pressure right now

@benjaminhuth
Copy link
Member Author

About composition over inheritance: While this is true in principle, the inheritance is relatively deeply baked into the class, e.g., instances are statically casted between single and multistepper...
I would leave it like this for now, maybe this can be addressed in a future refactor.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

📊: Physics performance monitoring for 31783b2

Full contents

physmon summary

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Aug 6, 2025
@benjaminhuth benjaminhuth changed the title feat!: Enable MultiStepper based on SympyStepper feat: Enable MultiStepper based on SympyStepper Aug 7, 2025
@benjaminhuth benjaminhuth modified the milestones: v44.0.0, next Aug 7, 2025
@benjaminhuth benjaminhuth requested a review from andiwand August 7, 2025 08:43
@benjaminhuth benjaminhuth marked this pull request as ready for review August 7, 2025 08:43
@paulgessinger paulgessinger modified the milestone: next Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Core Affects the Core module Component - Documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants