-
Notifications
You must be signed in to change notification settings - Fork 209
feat: Enable MultiStepper based on SympyStepper #4516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Enable MultiStepper based on SympyStepper #4516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like! 👍
IMO we could drop the MultiEigenStepperLoop.hpp
if this is a breaking change anyways
drafting because of ci failure and ci pressure right now |
About composition over inheritance: While this is true in principle, the inheritance is relatively deeply baked into the class, e.g., instances are statically casted between single and multistepper... |
This generalizes the
MultiEigenStepperLoop
to theMultiStepperLoop
, that can take an arbitrary single-component stepper as basis. The stepper concepts are modified accordingly. Tests for theMultiSympyStepperLoop
are added.The config constructor of the multi-stepper was broken (did not compile) and is now fixed. The change in that constructor is not considered breaking.
The
MultiEigenStepperLoop.hpp
header is kept for compatibility.