Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple-auth-server added to examples #65

Merged
merged 5 commits into from
Dec 9, 2018
Merged

Conversation

mygnu
Copy link
Contributor

@mygnu mygnu commented Dec 1, 2018

@Dowwie can you please have a look here, server implementation is complete now with tutorials

@fafhrd91
Copy link
Member

fafhrd91 commented Dec 8, 2018

I’d like to keep license same for all example. But we can add link to readme.

Copy link
Contributor

@DoumanAsh DoumanAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, there are some comments

.travis.yml Outdated Show resolved Hide resolved
simple-auth-server/LICENSE Outdated Show resolved Hide resolved
simple-auth-server/README.md Outdated Show resolved Hide resolved
simple-auth-server/README.md Outdated Show resolved Hide resolved
simple-auth-server/README.md Outdated Show resolved Hide resolved
simple-auth-server/src/auth_handler.rs Outdated Show resolved Hide resolved
simple-auth-server/src/auth_routes.rs Show resolved Hide resolved
simple-auth-server/src/email_service.rs Outdated Show resolved Hide resolved
simple-auth-server/src/email_service.rs Outdated Show resolved Hide resolved
simple-auth-server/src/register_handler.rs Show resolved Hide resolved
Copy link
Contributor

@DoumanAsh DoumanAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fafhrd91 Would you like to take a look too?

@fafhrd91
Copy link
Member

fafhrd91 commented Dec 9, 2018

My main concern is license. I’d like to keep same license for all examples, and I don’t want to see gpl especially

@DoumanAsh
Copy link
Contributor

Yep, same here, license file has been removed, so the only thing needed is to correct *.toml file

@DoumanAsh DoumanAsh merged commit 2fc76ac into actix:master Dec 9, 2018
@DoumanAsh
Copy link
Contributor

Thank you

@mygnu
Copy link
Contributor Author

mygnu commented Dec 9, 2018

No worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants