Fix stream draining for http/2 connections #290

actix · Jul 25, 2018 · 80fbc2e · 80fbc2e
1 parent f580650
commit 80fbc2e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -23,6 +23,8 @@
 
 * Missing response header "content-encoding" #421
 
+* Fix stream draining for http/2 connections #290
+
 
 ## [0.7.1] - 2018-07-21
 

diff --git a/src/pipeline.rs b/src/pipeline.rs
@@ -409,7 +409,7 @@ struct ProcessResponse<S, H> {
     _h: PhantomData<H>,
 }
 
-#[derive(PartialEq)]
+#[derive(PartialEq, Debug)]
 enum RunningState {
     Running,
     Paused,

diff --git a/src/server/h2.rs b/src/server/h2.rs
@@ -155,7 +155,9 @@ where
                         }
                     }
 
-                    if !item.flags.contains(EntryFlags::WRITE_DONE) {
+                    if item.flags.contains(EntryFlags::FINISHED)
+                        && !item.flags.contains(EntryFlags::WRITE_DONE)
+                    {
                         match item.stream.poll_completed(false) {
                             Ok(Async::NotReady) => (),
                             Ok(Async::Ready(_)) => {

diff --git a/src/server/h2writer.rs b/src/server/h2writer.rs
@@ -245,14 +245,18 @@ impl<H: 'static> Writer for H2Writer<H> {
                             let cap = cmp::min(self.buffer.len(), CHUNK_SIZE);
                             stream.reserve_capacity(cap);
                         } else {
+                            if eof {
+                                stream.reserve_capacity(0);
+                                continue;
+                            }
                             self.flags.remove(Flags::RESERVED);
-                            return Ok(Async::NotReady);
+                            return Ok(Async::Ready(()));
                         }
                     }
                     Err(e) => return Err(io::Error::new(io::ErrorKind::Other, e)),
                 }
             }
         }
-        Ok(Async::NotReady)
+        Ok(Async::Ready(()))
     }
 }