Skip to content

Conversation

Copy link

Copilot AI commented Jan 29, 2026

The pr-steps-checker.yml workflow had an unconditional exit 1 that blocked all PRs targeting main, regardless of PR content.

Changes

  • Replaced the failing blocker step with a no-op placeholder step
  • Removed conditional check that triggered exit 1 for main-targeted PRs
  • Preserves workflow structure for future implementation of actual checkbox validation

Before:

- name: Parse the PR description for all mandatory steps
  run: echo "Run blocker parser"
- if: ${{ contains(fromJson('["main"]'), github.event.pull_request.base.ref) }}
  name: Block merge due to missing mandatory steps
  run: exit 1
  shell: bash

After:

- name: Parse the PR description for all mandatory steps
  run: echo "Run blocker parser - Not implemented yet, skipping check"

PRs to main will no longer be automatically blocked by this workflow.

Original prompt

Problem

The workflow file .github/workflows/pr-steps-checker.yml is currently blocking ALL pull requests that target the main branch.

The Runner-steps job has an unconditional exit 1 that always fails when the PR targets main:

- if: ${{ contains(fromJson('["main"]'), github.event.pull_request.base.ref) }}
  # Failing step
  name: Block merge due to missing mandatory steps
  run: exit 1
  shell: bash

There is no actual parsing logic to check for mandatory checkboxes - it just echoes a message and then always fails.

Required Fix

In the file .github/workflows/pr-steps-checker.yml, replace the last two steps in the Runner-steps job (lines starting with "# RUN BLOCKER STEP") with a single step:

Replace:

      # RUN BLOCKER STEP
      - name: Parse the PR description for all mandatory steps
        run: echo "Run blocker parser"
      - if: ${{ contains(fromJson('["main"]'), github.event.pull_request.base.ref) }}
        # Failing step
        name: Block merge due to missing mandatory steps
        run: exit 1
        shell: bash

With:

      # RUN BLOCKER STEP
      - name: Parse the PR description for all mandatory steps
        run: echo "Run blocker parser - Not implemented yet, skipping check"

This removes the unconditional failure and allows PRs to proceed while keeping the placeholder comment for future implementation of actual checkbox validation logic.

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Maxoubu10 <70892917+Maxoubu10@users.noreply.github.com>
@sonarqubecloud
Copy link

@Maxoubu10 Maxoubu10 marked this pull request as ready for review January 29, 2026 16:11
@Maxoubu10 Maxoubu10 requested a review from a team as a code owner January 29, 2026 16:11
@Maxoubu10 Maxoubu10 merged commit dc576ec into bug/6.1/PIVOT-12499-bookmarks-aggregate-value-issue Jan 29, 2026
3 checks passed
@Maxoubu10 Maxoubu10 deleted the copilot/fix-pr-checker-workflow branch January 29, 2026 16:11
Copilot AI restored the copilot/fix-pr-checker-workflow branch January 29, 2026 16:11
Copilot AI changed the title [WIP] Fix PR workflow to correctly parse mandatory steps Fix workflow unconditionally blocking PRs to main Jan 29, 2026
Copilot AI requested a review from Maxoubu10 January 29, 2026 16:11
Copilot stopped work on behalf of Maxoubu10 due to an error January 29, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants