Don't pass :class option and a query parameter in generated url

activerecord-hackery · Mar 21, 2022 · 0e1d30e · 0e1d30e
1 parent f5160c1
commit 0e1d30e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/ransack/helpers/form_helper.rb b/lib/ransack/helpers/form_helper.rb
@@ -130,7 +130,7 @@ def name
 
         def url_options
           @params.merge(
-            @options.merge(
+            @options.except(:class).merge(
               @search.context.search_key => search_and_sort_params))
         end
 

diff --git a/spec/ransack/helpers/form_helper_spec.rb b/spec/ransack/helpers/form_helper_spec.rb
@@ -735,6 +735,7 @@ module Helpers
           )
         }
         it { should match /class="sort_link desc people"/ }
+        it { should_not match /people\?class=people/ }
       end
 
       describe '#sort_link with class option workaround' do
@@ -748,6 +749,7 @@ module Helpers
           )
         }
         it { should match /class="sort_link desc people"/ }
+        it { should_not match /people\?class=people/ }
       end
 
       describe '#search_form_for with default format' do