New Credit Card: Patagonia365 #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasb150
force-pushed
the
SER-1415_new_patagonia_card
branch
from
24ba721
to
0d60f0e
Compare
gasb150
force-pushed
the
SER-1415_new_patagonia_card
branch
from
0d60f0e
to
496f88f
Compare
naashton
requested changes
Nov 5, 2024
| @@ -54,7 +54,8 @@ module CreditCardMethods | |||
| 'panal' => ->(num) { num&.size == 16 && in_bin_range?(num.slice(0, 6), PANAL_RANGES) }, | |||
| 'verve' => ->(num) { (16..19).cover?(num&.size) && in_bin_range?(num.slice(0, 6), VERVE_RANGES) }, | |||
| 'tuya' => ->(num) { num =~ /^588800\d{10}$/ }, | |||
| 'uatp' => ->(num) { num =~ /^(1175|1290)\d{11}$/ } | |||
| 'uatp' => ->(num) { num =~ /^(1175|1290)\d{11}$/ }, | |||
| 'patagonia365' => ->(num) { num =~ /^504656\d{10}$/ } | |||
There was a problem hiding this comment.
This should be patagonia_365, sorry I didn't catch this sooner.
gasb150
force-pushed
the
SER-1415_new_patagonia_card
branch
3 times, most recently
from
6065879
to
99f541b
Compare
* Include the new Patagonia365 card type * Remove the same bin number from the Maestro list * Include the Patagonia365 card in the supported card list for the following gateways: - Adyen - Checkout V2 - Cybersource - Cybersource Rest - D Local - Decidir - DecidirPlus - Global Collect - Mercado Pago - Redsys - Redsys Rest - Worldpay [SER-1414](https://spreedly.atlassian.net/browse/SER-1414) [SER-1415](https://spreedly.atlassian.net/browse/SER-1415) Unit Tests: ---------------- Finished in 48.473175 seconds. 6040 tests, 80425 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop ---------------- 802 files inspected, no offenses detected
naashton
force-pushed
the
SER-1415_new_patagonia_card
branch
from
99f541b
to
b7ca8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the new Patagonia365 card type
Remove the same bin number from the Maestro list
Include the Patagonia365 card in the supported card list for the following gateways:
SER-1414
SER-1415
Unit Tests:
Finished in 48.473175 seconds.
6040 tests, 80425 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Rubocop
801 files inspected, no offenses detected