Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comp 71 apple pay recurring braintree blue #5258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdcano
Copy link
Contributor

@bdcano bdcano commented Sep 11, 2024

Description:
We removed the cryptogram In the BraintreeBlue active merchant adapter, when the stored_credential[:initiator] == 'merchant' in google pay and Apple Pay recurring payments

Local:
6026 tests, 80385 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
801 files inspected, no offenses detected
Unit:
127 tests, 668 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
123 tests, 662 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Copy link
Contributor

@aenand aenand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Please add 2 remote tests to the remote_braintree_blue_test.rb that test Apple Pay and Google Pay recurring then we should be good to go

lib/active_merchant/billing/gateways/braintree_blue.rb Outdated Show resolved Hide resolved
@KenderBolivarT KenderBolivarT force-pushed the COMP-71_apple_pay_recurring_braintree_blue branch 2 times, most recently from 1c3471f to 41f6676 Compare September 12, 2024 14:40
COMP-71

Adds support for Apple Pay and Google Pay recurring

Test Summary
Local:

Unit:

Remote:
Copy link

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

@github-actions github-actions bot added the Stale label Nov 13, 2024
@aenand aenand removed the Stale label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants