Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Litle: update the enhanced data field to return integer #5113

Merged
merged 1 commit into from
May 2, 2024

Conversation

yunnydang
Copy link
Contributor

Ensures we pass a integer to some of the enhanced data fields for visa and mastercard

Local:
5867 tests, 79303 assertions, 0 failures, 7 errors, 0 pendings, 0 omissions, 0 notifications
99.8807% passed

Unit:
59 tests, 264 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
57 tests, 251 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@yunnydang yunnydang requested a review from a team April 30, 2024 19:16
@yunnydang yunnydang self-assigned this Apr 30, 2024
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve since this change looks good, but would you also do us all the favor of correcting the Rubocop infractions that are currently in the master branch? 🙏🏻

@yunnydang yunnydang force-pushed the update_litle_enhanced_data_fields branch from 0726910 to ce87b72 Compare May 2, 2024 17:35
@yunnydang yunnydang force-pushed the update_litle_enhanced_data_fields branch from ce87b72 to 4b0ee60 Compare May 2, 2024 17:41
@yunnydang yunnydang merged commit 4b0ee60 into master May 2, 2024
0 of 5 checks passed
@yunnydang yunnydang deleted the update_litle_enhanced_data_fields branch May 2, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants