StripePI: Update eci format #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinHaefele
approved these changes
Apr 17, 2024
| def format_eci(payment_method, options) | ||
| eci_value = payment_method.respond_to?(:eci) ? payment_method.eci : options[:eci] | ||
|
|
||
| if eci_value.length == 1 |
There was a problem hiding this comment.
Suggested change
| if eci_value.length == 1 | |
| if eci_value&.length == 1 |
almalee24
force-pushed
the
update_stripe_eci_field
branch
from
727a64d
to
cfbab51
Compare
Update eci format to always be two digits. Unit: 60 tests, 311 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 93 tests, 444 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
update_stripe_eci_field
branch
from
cfbab51
to
6cfbd1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update eci format to always be two digits.
Unit:
60 tests, 311 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
93 tests, 444 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed