Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER-1083 Cecabank: exclude 3ds empty parameter #5021

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jherreraa
Copy link
Collaborator

@jherreraa jherreraa commented Jan 26, 2024

Summary:

This PR excludes the threeds node in the cecabank requests for the non three ds transactions

Unit Tests

Finished in 0.033172 seconds.
15 tests, 74 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote tests

Finished in 24.858862 seconds.
16 tests, 59 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.75% passed

test test_purchase_using_stored_credential_recurring_mit fails due to gateway rules

Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍 , left just one comment

@jherreraa jherreraa force-pushed the SER-1083-Cecabank_exclude_three_ds_empty_parameter branch from 4d5766b to 17f41c6 Compare January 29, 2024 16:13
@naashton naashton force-pushed the SER-1083-Cecabank_exclude_three_ds_empty_parameter branch from 17f41c6 to dcab76c Compare January 30, 2024 16:28
…n three ds transactions

Finished in 0.033172 seconds.
15 tests, 74 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Finished in 24.858862 seconds.
16 tests, 59 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
93.75% passed

test test_purchase_using_stored_credential_recurring_mit fails due to gateway rules
@naashton naashton force-pushed the SER-1083-Cecabank_exclude_three_ds_empty_parameter branch from dcab76c to fe40fba Compare January 30, 2024 16:29
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naashton naashton merged commit 4561ca3 into master Jan 30, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants