Priority: Allow gateway fields to be available on capture endpoint #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Looks good and tests pass. I noticed similar behavior with a possible limit on refund transactions. Seems odd, but since your changes are unrelated to refund I think it's fine to proceed. I left one note about a commented out section, so with the understanding that will be removed, 
yunnydang
force-pushed
the
CER-1167_priority_add_gsf_to_capture
branch
from
2e0d2fc
to
4e0b5e3
Compare
Local: 5800 tests, 78860 assertions, 0 failures, 26 errors, 0 pendings, 0 omissions, 0 notifications 99.5517% passed Unit: 21 tests, 145 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 31 tests, 84 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 83.871% passed
yunnydang
force-pushed
the
CER-1167_priority_add_gsf_to_capture
branch
from
4e0b5e3
to
853b91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to essentially allow the gateway fields to be available on the capture endpoint. Written the remote and unit tests to confirm this. I would note that the failing remote tests return the error message of rapid refund detected, so I'm assuming the sandbox has some rate limit attached.
Local:
5800 tests, 78860 assertions, 0 failures, 26 errors, 0 pendings, 0 omissions, 0 notifications 99.5517% passed
Unit:
21 tests, 145 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
31 tests, 84 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 83.871% passed