Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payeezy: Pull cardholder name from billing address #5006

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

almalee24
Copy link
Contributor

If payment method doesn't have name then pull it from the billing address for credit card cardholder name.

Remote:
52 tests, 212 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.0769% passed

Unit:
51 tests, 235 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

@almalee24 almalee24 requested a review from a team January 11, 2024 19:42
Copy link
Contributor

@DustinHaefele DustinHaefele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and straight forward.

Not sure why the gha test is failing but it doesn't look related to your change.

@almalee24
Copy link
Contributor Author

This looks good, and straight forward.

Not sure why the gha test is failing but it doesn't look related to your change.

Thanks! They're failing because Ruby needs to be updated

If payment method doesn't have name then pull it from the billing
address for credit card cardholder name.

Remote:
52 tests, 212 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
98.0769% passed

Unit:
51 tests, 235 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@almalee24 almalee24 merged commit acb138e into master Jan 17, 2024
0 of 5 checks passed
@almalee24 almalee24 deleted the update_payeezy_card_name branch January 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants