CommerceHub: Add dynamic descriptors #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunnydang
reviewed
Dec 20, 2023
| end | ||
|
|
||
| def add_dynamic_descriptors(post, options) | ||
| dynamic_descriptors_fields = %i[mcc merchant_name customer_service_number service_entitlement dynamic_descriptors_address] |
Adds the option to send dynamic descriptors on auth/capture or purchase https://developer.fiserv.com/product/CommerceHub/docs/?path=docs/Resources/Guides/Dynamic-Descriptor.md&branch=main CER-1077 LOCAL 5758 tests, 78786 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 784 files inspected, no offenses detected UNIT 28 tests, 194 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed REMOTE -> When running the full remote test suite, I see between 16-18 failures each time, each of which has the message `"The transaction limit was exceeded. Please try again!"` When I run the failing tests individually, all of them pass, with a few exceptions: test_successful_credit (merchant account configuration) test_successful_purchase_with_encrypted_credit_card (merchant account configuration) test_successful_store_with_purchase (invalid expiration date?) None of these failures appear to be related to the changes here.
jcreiff
force-pushed
the
commerce_hub_dynamic_descriptors
branch
from
5160230
to
65bd0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to send dynamic descriptors on auth/capture or purchase
https://developer.fiserv.com/product/CommerceHub/docs/?path=docs/Resources/Guides/Dynamic-Descriptor.md&branch=main
CER-1077
LOCAL
5758 tests, 78786 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
784 files inspected, no offenses detected
UNIT
28 tests, 194 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
REMOTE
-> When running the full remote test suite, I see between 16-18 failures each time, each of which has the message
"The transaction limit was exceeded. Please try again!"When I run the failing tests individually, all of them pass, with a few exceptions:
test_successful_credit(merchant account configuration)test_successful_purchase_with_encrypted_credit_card(merchant account configuration)test_successful_store_with_purchase(invalid expiration date?)None of these failures appear to be related to the changes here.