Rapyd: Enable idempotent request support #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarv09
reviewed
Dec 7, 2023
edgarv09
reviewed
Dec 7, 2023
javierpedrozaing
force-pushed
the
SER-1023_rapyd_add_idempotency
branch
2 times, most recently
from
fa9df13
to
a5478fa
Compare
|
Hi @naashton I will update the idempotency key name according a suggestion from Cristian on the CORE PR. I let you know when it is ready |
javierpedrozaing
force-pushed
the
SER-1023_rapyd_add_idempotency
branch
from
a5478fa
to
3504aa8
Compare
Update ready. thanks |
Description ------------------------- [SER-1023](https://spreedly.atlassian.net/browse/SER-1023) This commit adds an idempotency attribute to headers in order to support idempotent requests, Rapyd manage it, taking into account the idempotency value and the amount to determine if a transaction is idempotent or no. Unit test ------------------------- Finished in 0.504217 seconds. 42 tests, 196 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 83.30 tests/s, 388.72 assertions/s Remote test ------------------------- 49 tests, 142 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.9592% passed Rubocop ------------------------- 784 files inspected, no offenses detected
naashton
force-pushed
the
SER-1023_rapyd_add_idempotency
branch
from
3504aa8
to
de033be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-1023
This commit adds an idempotency attribute to headers in order to support idempotent requests, Rapyd manage it, taking into account the idempotency value and the amount to determine if a transaction is idempotent or no.
Unit test
Finished in 0.504217 seconds.
42 tests, 196 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
83.30 tests/s, 388.72 assertions/s
Remote test
49 tests, 142 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.9592% passed
Rubocop
784 files inspected, no offenses detected