Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER-705 Nexi Xpay Void, Refund, Verify #4978

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

jherreraa
Copy link
Collaborator

Description

SER-705

This commit add NexiXpay operations, void, refund, verify

@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch 2 times, most recently from 42603a2 to cad388d Compare December 4, 2023 20:04
@jherreraa jherreraa changed the base branch from master to SER-703_nexiXpay_add_basic_transaction_through_3ds December 4, 2023 20:05
Copy link
Contributor

@sinourain sinourain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small comments, and I am left wondering why there are no remote tests for new transactions?

lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch from cad388d to 0ad2f84 Compare December 6, 2023 20:09
@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch from 0ad2f84 to 7f7ebd6 Compare December 7, 2023 12:49
@jherreraa jherreraa force-pushed the SER-703_nexiXpay_add_basic_transaction_through_3ds branch from 191495e to 8ab32be Compare December 12, 2023 13:33
@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch 5 times, most recently from 5edbfe2 to d3dc618 Compare December 12, 2023 22:12
@jherreraa jherreraa marked this pull request as ready for review December 13, 2023 19:19
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be some overlap between this and the other PR. Once we finish up the other PR, we can rebase this and re-review this.

lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
@jherreraa jherreraa force-pushed the SER-703_nexiXpay_add_basic_transaction_through_3ds branch from 8ab32be to 07adbb3 Compare December 15, 2023 15:27
@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch from d3dc618 to 88d10b3 Compare December 15, 2023 15:29
@jherreraa jherreraa force-pushed the SER-703_nexiXpay_add_basic_transaction_through_3ds branch from 07adbb3 to 4c0c3b3 Compare December 15, 2023 19:16
@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch 2 times, most recently from 4306fc3 to cc147e3 Compare December 19, 2023 20:41
@jherreraa jherreraa force-pushed the SER-705_nexiXpay_add_void_refund_verify branch from cc147e3 to 362ef93 Compare December 19, 2023 20:46
@jherreraa jherreraa changed the base branch from SER-703_nexiXpay_add_basic_transaction_through_3ds to master December 19, 2023 20:47
Description
-------------------------
[SER-703](https://spreedly.atlassian.net/browse/SER-703)

This commit add NexiXpay gateway with its basic operations
Description
-------------------------
[SER-703](https://spreedly.atlassian.net/browse/SER-703)

This commit add NexiXpay gateway with its basic operations
@naashton naashton force-pushed the SER-705_nexiXpay_add_void_refund_verify branch from 362ef93 to f46e1fe Compare December 20, 2023 16:48
Description
-------------------------
[SER-705](https://spreedly.atlassian.net/browse/SER-705)

This commit add NexiXpay operations, void, refund, verify
@naashton naashton force-pushed the SER-705_nexiXpay_add_void_refund_verify branch from f46e1fe to 4b88976 Compare December 20, 2023 16:48
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@naashton naashton merged commit 2d0ed3f into master Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants