SafeCharge: Support tokens #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
requested changes
Nov 8, 2023
|
|
||
| def add_network_token(post, payment, options) | ||
| post[:sg_CAVV] = payment.payment_cryptogram | ||
| post[:sg_ECI] = options[:three_d_secure] && options[:three_d_secure][:eci] || '05' |
There was a problem hiding this comment.
Should this be the ECI for the network token or the 3DS ECI value?
There was a problem hiding this comment.
Oh that's a good question, probably the network token. Since this is not related to the ticket and it will need some additional testing I'll create a ticket for it.
Yes, I'll do that. |
almalee24
force-pushed
the
safe_charge_use_token
branch
2 times, most recently
from
1875239
to
a72ea3d
Compare
almalee24
force-pushed
the
safe_charge_use_token
branch
from
a72ea3d
to
1d396aa
Compare
Allow processing payments sith tokens. A token is returned by SafeCharge in the previous response to represent the customers' credit card. Remote: 34 tests, 96 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 30 tests, 160 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
safe_charge_use_token
branch
from
1d396aa
to
7108e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote:
34 tests, 96 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit:
29 tests, 160 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed