GlobalCollect: Add support for 3DS exemptions #4917
Conversation
almalee24
force-pushed
the
global_collect_3ds_exemptions
branch
from
0ec47bd
to
2bf77e1
Compare
| moto: 'MOTO', | ||
| mail: 'MAIL', | ||
| telephone: 'TELEPHONE', | ||
| ecommerce: 'ECOMMERCE' |
There was a problem hiding this comment.
I'm surprised there's moto, telephone, and mail since MOTO stands for mail order telephone order. Does the gateway specify when to use moto vs the other two?
There was a problem hiding this comment.
I know but it doesn't specify when to use which. Now I'm actually thinking about removing ecommerce since it says that's the default value.
There was a problem hiding this comment.
MAIL - The transaction is a Mail Order.
MOTO - The transaction is a Mail Order/Telephone Order.
TELEPHONE - The transaction is a Telephone Order.
Did the merchant specifically reqest to add MAIL and TELEPHONE? If not then I'd suggest we just add MOTO
There was a problem hiding this comment.
We want to support all available exemption types which is why I added mail and telephone but it does seem redundant with them also supporting MOTO
nice work! I'm wary about adding 
I think you are right so I will remove mail and telephone |
almalee24
force-pushed
the
global_collect_3ds_exemptions
branch
2 times, most recently
from
4e5daef
to
8265e67
Compare
Remote 53 tests, 121 assertions, 10 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 79.2453% passed Unit 46 tests, 234 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
global_collect_3ds_exemptions
branch
from
8265e67
to
ba4a1e3
Compare
Remote
53 tests, 121 assertions, 10 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 79.2453% passed
Unit
46 tests, 234 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed