Adyen: Update MIT flagging for NT #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
force-pushed
the
update_adyen_flagging
branch
from
6089325
to
bcd486b
Compare
bradbroge
reviewed
Oct 3, 2023
almalee24
reviewed
Oct 3, 2023
almalee24
reviewed
Oct 3, 2023
aenand
force-pushed
the
update_adyen_flagging
branch
from
bcd486b
to
8df453b
Compare
aenand
commented
Oct 4, 2023
aenand
force-pushed
the
update_adyen_flagging
branch
from
8df453b
to
778ee90
Compare
ECS-3158 The existing logic for MIT flagging for any NT card (ApplePay, GooglePay, or NetworkToken) assume that they cannot be used with a `shopperInteraction` of `ContAuth`. This is not true as a merchant can perform MIT transactions with these payment methods if they skip adding MPI data. This commit updates the `shopper_interaction` logic so that NT payment methods on subsequent transactions will be flagged as `ContAuth` and skip adding MPI data for them. This commit also comments out Adyen's remote store tests as they are failing. A new ticket, ECS-3205, has been created to fix them. Remote Tests: 128 tests, 449 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
aenand
force-pushed
the
update_adyen_flagging
branch
from
778ee90
to
50e246e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS-3158
The existing logic for MIT flagging for any NT card (ApplePay, GooglePay, or NetworkToken) assume that they cannot be used with a
shopperInteractionofContAuth. This is not true as a merchant can perform MIT transactions with these payment methods if they skip adding MPI data.This commit updates the
shopper_interactionlogic so that NT payment methods on subsequent transactions will be flagged asContAuthand skip adding MPI data for them.This commit also comments out Adyen's remote store tests as they are failing. A new ticket, ECS-3205, has been created to fix them.
Remote Tests:
126 tests, 433 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed