Authorize.net: truncate nameOnAccount for bank refunds #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
approved these changes
Jun 13, 2023
| @@ -835,6 +835,18 @@ def test_successful_echeck_refund | |||
| assert_match %r{The transaction cannot be found}, refund.message, 'Only allowed to refund transactions that have settled. This is the best we can do for now testing wise.' | |||
| end | |||
|
|
|||
| def test_successful_echeck_refund_truncates_long_account_name | |||
| check_with_long_name = check(name: 'Michelangelo Donatello-Raphael') | |||
| purchase = @gateway.purchase(@amount, check_with_long_name, @options) | |||
There was a problem hiding this comment.
You got beef with Leonardo?
The API specification requires that the string be no longer than 22 characters; refunds will fail if this limit is exceeded CER-670 REMOTE 85 tests, 304 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed UNIT 122 tests, 688 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed LOCAL 5525 tests, 77482 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 760 files inspected, no offenses detected
jcreiff
force-pushed
the
authorize_net_nameOnAccount_truncate
branch
from
2720a9c
to
7fbffa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API specification requires that the string be no longer than 22 characters; refunds will fail if this limit is exceeded
CER-670
REMOTE
85 tests, 304 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
UNIT
122 tests, 688 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
LOCAL
5525 tests, 77482 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
760 files inspected, no offenses detected