Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credorax: Update OpCode for Credit transactions #4505

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

therufs
Copy link
Contributor

@therufs therufs commented Jul 19, 2022

Credit should now be using O=35 instead of O=6

CE-2235
CER-64

Rubocop:
746 files inspected, no offenses detected

Unit:
80 tests, 381 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
46 tests, 157 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.9565% passed

Credit should now be using `O=35` instead of `O=6`

CE-2235

Rubocop:
728 files inspected, no offenses detected

Unit:
5038 tests, 74956 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
45 tests, 164 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@therufs therufs requested a review from a team July 19, 2022 19:12
@therufs therufs self-assigned this Jul 19, 2022
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems to be a straightforward change according to Credorax's direction.

Tests are passing for me except for the noted remote ones, which don't seem to be related to this functionality.

🚢

@therufs therufs merged commit 7d15705 into activemerchant:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants