Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credorax: Update processor response messages #4466

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jcreiff
Copy link
Contributor

@jcreiff jcreiff commented Jun 21, 2022

This change updates the RESPONSE_MESSAGES hash to match what is found
in the most recent version of Credorax's API docs:
https://epower.credorax.com/

Test Summary:

Local: 5213 tests, 75896 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit: 78 tests, 374 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 46 tests, 157 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.9565% passed

(These remote test failures have existed since a02d735)

@jcreiff jcreiff requested a review from a team June 21, 2022 21:11
Copy link
Contributor

@therufs therufs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me and tests behave as described. Don't forget the CHANGELOG entry!

This change updates the `RESPONSE_MESSAGES` hash to match what is found
in the most recent version of Credorax's API docs:
https://epower.credorax.com/

Test Summary:

Local: 5213 tests, 75896 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit: 78 tests, 374 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 46 tests, 157 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.9565% passed

(These remote test failures have existed since a02d735)
@jcreiff jcreiff force-pushed the CER-11_credorax_processor_response branch from 8f4fb32 to ebdb25c Compare June 22, 2022 19:35
@jcreiff jcreiff merged commit ebdb25c into master Jun 22, 2022
@jcreiff jcreiff deleted the CER-11_credorax_processor_response branch June 22, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants