Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moneris: ensure all remote tests pass #4354

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

esmitperez
Copy link
Contributor

Prior to this change, only 97% of tests passed.

Requirements:

ECS-1882

Unit: 51 tests, 274 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 40 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Prior to this change, only 97% of tests passed.

Requirements:
- Ensure your `fixtures.yml` uses `store5/yesguy` from [Testing a
  Solution](https://developer.moneris.com/More/Testing/Testing%20a%20Solution)
document

ECS-1882

Unit: 51 tests, 274 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 40 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Copy link
Contributor

@aenand aenand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@BritneyS BritneyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass that I expected to. Thanks for repairing this test ahead of our work :)

5072 tests, 75084 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications
99.6648% passed (Monei had errors)

51 tests, 274 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

40 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@esmitperez esmitperez merged commit 855d424 into master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants