DecidirPlus: Handle payment_method_id by card_brand
#4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmcclain
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
All tests are passing.
The logic in this case statement is straightforward enough. I have no idea how this payment_method_id connects to the underlying issue with bin described in the ticket, but I trust that you have done your research and that this solves the problem.
Made a few nitpicky comments about testing, take them or leave them. Approving but happy to re-review if you want to make adjustments.
Don't forget the ChAnGeLoG! 😄
naashton
force-pushed
the
CE-2424-decidir_plus_payment_method_ids
branch
2 times, most recently
from
82be822
to
50282cb
Compare
Determine `payment_method_id` based on `card_brand` passed in the options hash for auth and purchase transactions CE-2424 Unit: 13 tests, 53 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote0: 17 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
naashton
force-pushed
the
CE-2424-decidir_plus_payment_method_ids
branch
from
50282cb
to
b9547e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine
payment_method_idbased oncard_brandpassed in theoptions hash for auth and purchase transactions
CE-2424
Unit: 13 tests, 53 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote0: 17 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed