Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubocop UnusedMethodArgument #3646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdmackeyfree
Copy link
Contributor

4466 tests, 71579 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

4466 tests, 71579 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@cdmackeyfree cdmackeyfree requested a review from a team May 29, 2020 15:18
@@ -0,0 +1,352 @@
require 'rexml/document'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... where did this file come from??? :confused_england:

@@ -129,8 +129,13 @@ def credit(money, authorization, options = {})
refund(money, authorization, options)
end

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small thing to clean up here

Copy link
Contributor

@therufs therufs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the output of performing bundle exec rubocop -a on the parent commit to this one and it looks mostly good -- just a couple of things to clean up (which I think will also get Travis to be less grumpy) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants