Paymentez: Read messages on Failure with no error #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was unable to reproduce the error with a card with an old year, so I think expired here means something different. Thats why only the unit test. |
curiousepic
reviewed
May 18, 2018
| if response['error'] | ||
| response['error'] && response['error']['type'] | ||
| else | ||
| response['transaction']['message'] |
There was a problem hiding this comment.
It might be worth considering concatenating "transaction_message: error_type" in this case, which we do for some other gateways. Unless we know there is no transaction message if there is an error.
There was a problem hiding this comment.
Might be misunderstanding, but it looks like its one or the other. We get back an error or a transaction.
Extends parsing messages on failure. Messages can be returned that are not included in the error field. Loaded suite test/unit/gateways/paymentez_test ................ 16 tests, 48 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/remote/gateways/remote_paymentez_test ................ 16 tests, 39 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends parsing messages on failure. Messages can be returned that are not included in the error
field.
Loaded suite test/unit/gateways/paymentez_test
................
16 tests, 48 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Loaded suite test/remote/gateways/remote_paymentez_test
................
16 tests, 39 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed