Worldpay US: Fix bank account scrub #2748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong field was being scrubbed for the bank account number. Also adds unit tests for scrubbing. One known unrelated remote test failure. Unit: 17 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 15 tests, 45 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed
curiousepic
requested review from
bpollack,
dtykocki,
nfarve and
deedeelavinder
molejnik-mergebit
pushed a commit
to molejnik-mergebit/active_merchant
that referenced
this pull request
Feb 22, 2018
The wrong field was being scrubbed for the bank account number. Also adds unit tests for scrubbing. One known unrelated remote test failure. Closes activemerchant#2748 Unit: 17 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 15 tests, 45 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong field was being scrubbed for the bank account number. Also
adds unit tests for scrubbing.
One known unrelated remote test failure.
Unit:
17 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
15 tests, 45 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
93.3333% passed